Skip to content

handle space in the directory path. #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

handle space in the directory path. #2925

merged 1 commit into from
Mar 13, 2019

Conversation

andrewkittredge
Copy link
Contributor

@andrewkittredge andrewkittredge commented Mar 12, 2019 •
edited by Ivanidzo4ka
Loading

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fixes #191

@sfilipi sfilipi requested a review from eerhardt March 12, 2019 16:49
@eerhardt eerhardt requested review from Anipik and safern March 12, 2019 16:59
eerhardt
eerhardt approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix.

init-tools.cmd
@@ -75,7 +75,7 @@ if NOT exist "%DOTNET_LOCAL_PATH%" (
if exist "%BUILD_TOOLS_PATH%" goto :afterbuildtoolsrestore
echo Restoring BuildTools version %BUILDTOOLS_VERSION%...
echo Running: "%DOTNET_CMD%" restore "%INIT_TOOLS_RESTORE_PROJECT%" --no-cache --packages "%PACKAGES_DIR%" --source "%BUILDTOOLS_SOURCE%" /p:BuildToolsPackageVersion=%BUILDTOOLS_VERSION% /p:ToolsDir=%TOOLRUNTIME_DIR% >> "%INIT_TOOLS_LOG%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix up this line to match the line below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still does not build because I have a space in my path.

When I run -
C:\Users\Andrew Kittredge\Source\Repos\machinelearning\src\Native> .\build.cmd.

I get

CMake Error: The source directory "C:/Users/Andrew Kittredge/Source/Repos/machinelearning/bin/obj/x64.Debug/Native/Kittredge/Source/Repos/machinelearning/src/Native"".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewkittredge - I don't understand your comment. Are you saying your change didn't fix the issue you said it is fixing?

My comment here is regarding that this line echo command is supposed to be a duplicate of command. So if you change the command line - we should keep the echo command line up-to-date.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this fixed before merge? @TomFinley , @eerhardt

Anipik
Anipik approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@Anipik Anipik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #2925 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
- Coverage   71.82%   71.82%   -0.01%     
==========================================
  Files         812      812              
  Lines      142719   142719              
  Branches    16092    16092              
==========================================
- Hits       102511   102510       -1     
  Misses      35830    35830              
- Partials     4378     4379       +1
Flag Coverage Δ
#Debug 71.82% <ø> (-0.01%) ⬇️
#production 67.97% <ø> (-0.01%) ⬇️
#test 86.21% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...StandardTrainers/Standard/LinearModelParameters.cs 60.63% <0%> (-0.27%) ⬇️
...rc/Microsoft.ML.Transforms/Text/TextNormalizing.cs 97.11% <0%> (ø) ⬆️

@TomFinley TomFinley merged commit fa9268d into dotnet:master Mar 13, 2019
@eerhardt eerhardt mentioned this pull request Apr 9, 2019
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shauheen shauheen shauheen left review comments

@eerhardt eerhardt eerhardt approved these changes

@Anipik Anipik Anipik approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project will not build because of space in build path
6 participants
@andrewkittredge @shauheen @eerhardt @Anipik @safern @TomFinley