Skip to content

Move ONNX Transformer into Microsoft.ML.Transforms.Onnx namespace. #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2019
Merged

Move ONNX Transformer into Microsoft.ML.Transforms.Onnx namespace. #2929

merged 2 commits into from
Mar 14, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Mar 12, 2019

towards #2751

@codemzs codemzs requested review from sfilipi and TomFinley March 12, 2019 18:27
@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #2929 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   72.19%   72.18%   -0.01%     
==========================================
  Files         796      796              
  Lines      142023   142023              
  Branches    16046    16046              
==========================================
- Hits       102530   102525       -5     
- Misses      35114    35118       +4     
- Partials     4379     4380       +1
Flag Coverage Δ
#Debug 72.18% <ø> (-0.01%) ⬇️
#production 67.97% <ø> (-0.01%) ⬇️
#test 88.3% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...OnnxTransformer.StaticPipe/OnnxStaticExtensions.cs 100% <ø> (ø) ⬆️
test/Microsoft.ML.Tests/OnnxConversionTest.cs 97.22% <ø> (ø) ⬆️
src/Microsoft.ML.OnnxTransformer/OnnxCatalog.cs 100% <ø> (ø) ⬆️
...t.ML.OnnxTransformerTest/DnnImageFeaturizerTest.cs 97.32% <ø> (ø) ⬆️
...r.StaticPipe/DnnImageFeaturizerStaticExtensions.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 77.31% <ø> (ø) ⬆️
src/Microsoft.ML.OnnxTransformer/OnnxTransform.cs 86.24% <ø> (ø) ⬆️
....ML.OnnxTransformer/DnnImageFeaturizerTransform.cs 95.23% <ø> (ø) ⬆️
...L.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs 100% <ø> (ø) ⬆️
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
... and 3 more

sfilipi
sfilipi reviewed Mar 13, 2019
View reviewed changes
sfilipi
sfilipi approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@sfilipi sfilipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

TomFinley
TomFinley approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codemzs !!

TomFinley
TomFinley approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @codemzs !

src/Microsoft.ML.DnnImageFeaturizer.ResNet18/ResNet18Extension.cs

namespace Microsoft.ML.Transforms
namespace Microsoft.ML
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, I had forgotten about these extensions.

@TomFinley TomFinley merged commit a6a9d9d into dotnet:master Mar 14, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomFinley TomFinley TomFinley approved these changes

@sfilipi sfilipi sfilipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codemzs @TomFinley @sfilipi