Skip to content

Move transform catalog extensions into its own file and class in experimental nuget. #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Mar 25, 2019

Transform catalog extension methods are misplaced in MlContextExtensions.cs file. They need to go in a file of its own.

fixes #3081

@artidoro
Copy link
Contributor

Hey @codemzs, I think we need to add them back to another file. Did you mean to add that to this commit?

@codemzs codemzs changed the title Move transform catalog extensions into its own class in experimental nuget. Move transform catalog extensions into its own file and class in experimental nuget. Mar 25, 2019
@codemzs
Copy link
Member Author

codemzs commented Mar 25, 2019

@artidoro That is correct, thanks.

Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it does look better like this!

Copy link
Member

@abgoswam abgoswam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 9926f98 into dotnet:master Mar 25, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move transform catalog extensions into its own class in experimental nuget.
3 participants