Updating .tt file due to renaming of LbfgsPoissonRegression. #3140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3140 +/- ##
==========================================
+ Coverage 72.52% 72.53% +0.01%
==========================================
Files 808 808
Lines 144665 144740 +75
Branches 16198 16202 +4
==========================================
+ Hits 104912 104987 +75
- Misses 35342 35343 +1
+ Partials 4411 4410 -1
|
should we fix this as well ? #Resolved Refers to: src/Microsoft.ML.StandardTrainers/StandardTrainersCatalog.cs:596 in 430a999. [](commit_id = 430a999, deletion_comment = False) |
fix this too ? #Resolved Refers to: src/Microsoft.ML.StandardTrainers/StandardTrainersCatalog.cs:596 in 430a999. [](commit_id = 430a999, deletion_comment = False) |
| @@ -567,7 +567,7 @@ public static LbfgsLogisticRegressionBinaryTrainer LbfgsLogisticRegression(this | |||
| /// <example> | |||
| /// <format type="text/markdown"> | |||
| /// <] | |||
| /// [!code-csharp[PoissonRegression](~/../docs/samples/docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Regression/LbfgsPoissonRegression.cs)] | |||
There was a problem hiding this comment.
PoissonRegression [](start = 27, length = 17)
?
There was a problem hiding this comment.
There was a problem hiding this comment.
This is the alt-text for the link, so it should be the name of the API.
In reply to: 270973957 [](ancestors = 270973957,270581846)
| @@ -567,7 +567,7 @@ public static LbfgsLogisticRegressionBinaryTrainer LbfgsLogisticRegression(this | |||
| /// <example> | |||
| /// <format type="text/markdown"> | |||
| /// <] | |||
| /// [!code-csharp[PoissonRegression](~/../docs/samples/docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/Regression/LbfgsPoissonRegression.cs)] | |||
| /// ]]></format> | |||
| /// </example> | |||
| public static LbfgsPoissonRegressionTrainer LbfgsPoissonRegression(this RegressionCatalog.RegressionTrainers catalog, | |||
There was a problem hiding this comment.
LbfgsPoissonRegressionTrainer [](start = 22, length = 29)
there were other renamings which accompanied this .. should we fix those too in this PR ?
#3016 (comment) #Resolved
There was a problem hiding this comment.
Rest of the examples are not using .tt or they have been converted to .tt after the above change. So, those are fine right now.
In reply to: 270582198 [](ancestors = 270582198)
| <Generator>TextTemplatingFileGenerator</Generator> | ||
| <LastGenOutput>PoissonRegression.cs</LastGenOutput> | ||
| <LastGenOutput>LbfgsPoissonRegression.cs</LastGenOutput> | ||
| </None> | ||
| <None Update="Dynamic\Trainers\Regression\PoissonRegressionWithOptions.tt"> |
There was a problem hiding this comment.
PoissonRegressionWithOptions [](start = 46, length = 28)
please also fix this in the same way #Closed
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This PR fixes the issue related to renaming done in #3034. Currently, we are finding a way to forcing people to update the .tt file instead of .cs file generated from .tt.