-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Time Series samples for stateful prediction engine. #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectChangePointBySsaBatchPrediction.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectIidChangePoint.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3213 +/- ##
=======================================
Coverage 72.62% 72.62%
=======================================
Files 807 807
Lines 145080 145080
Branches 16213 16213
=======================================
Hits 105369 105369
- Misses 35294 35295 +1
+ Partials 4417 4416 -1
|
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectIidSpike.cs
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectChangePointBySsa.cs
Outdated
Show resolved
Hide resolved
did you want to update those to the new files? Also, you can write in the CDATA, so that the examples have some sort of explanation on them. Refers to: src/Microsoft.ML.TimeSeries/PredictionFunction.cs:272 in cab1b81. [](commit_id = cab1b81, deletion_comment = False) |
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectChangePointBySsa.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectChangePointBySsa.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectChangePointBySsa.cs
Outdated
Show resolved
Hide resolved
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectIidChangePoint.cs
Outdated
Show resolved
Hide resolved
suggestion: let's call the data in all timeseries samples TimeSeriesData. There's nothing in the data that makes it IidChangePointData. In fact the same data can be used with all of the timeseries transforms. #Resolved Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectIidChangePoint.cs:21 in 3aea63a. [](commit_id = 3aea63a, deletion_comment = False) |
suggestion: can we make these inline like this? it won't need preview and it's easier to see the data. machinelearning/docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/Text/ProduceWordBags.cs Line 18 in fc89745
#Resolved Refers to: docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/TimeSeries/DetectIidChangePoint.cs:46 in 3aea63a. [](commit_id = 3aea63a, deletion_comment = False) |
I updated the file paths. Don't see any reason to write in CDATA because this is how we are doing it everywhere else. Lets be consistent and not waste time on small details. In reply to: 480445339 [](ancestors = 480445339) Refers to: src/Microsoft.ML.TimeSeries/PredictionFunction.cs:272 in 3aea63a. [](commit_id = 3aea63a, deletion_comment = False) |
3aea63a
to
cab1b81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, in here, just a sentence in between the examples. /// This is an example on how to identify changing points in the time series, accounting for seasonality. In reply to: 481765669 [](ancestors = 481765669,480445339) Refers to: src/Microsoft.ML.TimeSeries/PredictionFunction.cs:272 in cab1b81. [](commit_id = cab1b81, deletion_comment = False) |
I understand, however this pattern does not seem to be used elsewhere in the codebase. I look around and I see just links. Like I said, lets not waste time on details and just be consistent and move fast. In reply to: 481867193 [](ancestors = 481867193,481765669,480445339) Refers to: src/Microsoft.ML.TimeSeries/PredictionFunction.cs:272 in cab1b81. [](commit_id = cab1b81, deletion_comment = False) |
I'll add it in another PR ;) In reply to: 481867611 [](ancestors = 481867611,481867193,481765669,480445339) Refers to: src/Microsoft.ML.TimeSeries/PredictionFunction.cs:272 in cab1b81. [](commit_id = cab1b81, deletion_comment = False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add time series samples for stateful prediction engine. * PR feedback. * PR feedback. * PR feedback. * cleanup. * PR feedback. * cleanup.
fixes #3277
Seems like PR #2900 removed the stateful prediction samples as part of refactoring and cleanup. Adding these useful samples back as they are used by customers that want to save time series model to disk and reload the model with up to date state that contains last seen values from prediction phase.