Fix runtime exception in MapKeyToVector sample. #3287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemzs
commented
Apr 11, 2019
| @@ -67,8 +67,8 @@ private class DataPoint | |||
|
|
|||
| private class TransformedData : DataPoint | |||
| { | |||
| public uint[] TimeframeVector { get; set; } | |||
| public uint[] CategoryVector { get; set; } | |||
| public float[] TimeframeVector { get; set; } | |||
There was a problem hiding this comment.
the other option is leave it as uint[] but add another transform in the pipeline that converts these column types from float to uint but this is not currently possibly because we don't have float to uint converter in Conversions.cs but of course that can be added and we can use C#'s convention for conversion to uint by casting.
CC: @TomFinley
There was a problem hiding this comment.
I think changing the type is appropriate -- this is a key-to-vector sample, the output type of key-to-vector is a float vector, so, this change seems appropriate at least to me.
Codecov Report
@@ Coverage Diff @@
## master #3287 +/- ##
==========================================
- Coverage 72.63% 72.63% -0.01%
==========================================
Files 807 807
Lines 145129 145129
Branches 16220 16220
==========================================
- Hits 105417 105414 -3
- Misses 35294 35297 +3
Partials 4418 4418
|
TomFinley
approved these changes
Apr 11, 2019
eerhardt
approved these changes
Apr 11, 2019
codemzs
added a commit
to codemzs/machinelearning
that referenced
this pull request
Apr 11, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3286