Skip to content

Setting metadata back to defaults for Microsoft.ML.DataView #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2019
Merged

Setting metadata back to defaults for Microsoft.ML.DataView #3367

merged 1 commit into from
Apr 17, 2019

Conversation

shauheen
Copy link
Contributor

Fixes #3366

@shauheen shauheen requested a review from eerhardt April 16, 2019 22:42
eerhardt
eerhardt approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going into 1.0 right?

@shauheen shauheen requested a review from glebuk April 17, 2019 03:37
@shauheen
Copy link
Contributor Author

This is going into 1.0 right?

That is correct.

TomFinley
TomFinley approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@TomFinley TomFinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @shauheen

@eerhardt eerhardt merged commit 73e29c8 into dotnet:master Apr 17, 2019
@shauheen shauheen deleted the fix_nuget branch April 17, 2019 21:53
@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@TomFinley TomFinley TomFinley approved these changes

@glebuk glebuk Awaiting requested review from glebuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.ML.DataView metadat needs to be fixed
3 participants
@shauheen @eerhardt @TomFinley