Towards #3204 - Documentation for MLContext.Transforms.Categorical #3388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3388 +/- ##
==========================================
+ Coverage 72.69% 72.7% +<.01%
==========================================
Files 807 807
Lines 145172 145171 -1
Branches 16225 16225
==========================================
+ Hits 105533 105542 +9
+ Misses 35223 35217 -6
+ Partials 4416 4412 -4
|
Codecov Report
@@ Coverage Diff @@
## master #3388 +/- ##
=======================================
Coverage 72.76% 72.76%
=======================================
Files 808 808
Lines 145452 145452
Branches 16244 16244
=======================================
Hits 105842 105842
Misses 35189 35189
Partials 4421 4421
|
natke
suggested changes
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
natke
approved these changes
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
Ivanidzo4ka
reviewed
Apr 19, 2019
nit: There are some very long line in this document could you break them up? #Resolved Refers to: src/Microsoft.ML.Transforms/CategoricalCatalog.cs:30 in 75fb8c4. [](commit_id = 75fb8c4, deletion_comment = False) |
artidoro
reviewed
Apr 20, 2019
shmoradims
reviewed
Apr 20, 2019
shmoradims
reviewed
Apr 20, 2019
artidoro
force-pushed
the
3204_categorical
branch
from
75fb8c4 to
ae63aea
Compare
shauheen
reviewed
Apr 21, 2019
shauheen
reviewed
Apr 21, 2019
shauheen
reviewed
Apr 21, 2019
glebuk
reviewed
Apr 21, 2019
sfilipi
reviewed
Apr 21, 2019
shauheen
approved these changes
Apr 21, 2019
sfilipi
reviewed
Apr 21, 2019
| /// | ||
| /// The output of this transform is specified by <xref:Microsoft.ML.Transforms.OneHotEncodingEstimator.OutputKind>: | ||
| /// | ||
| /// - <xref:Microsoft.ML.Transforms.OneHotEncodingEstimator.OutputKind.Indicator> produces an [indicator vector](https://en.wikipedia.org/wiki/Indicator_vector). |
There was a problem hiding this comment.
- [](start = 8, length = 1)
just checking: is this valid for markdown lists? I've always used *
There was a problem hiding this comment.
Both produce the same bullet
sfilipi
reviewed
Apr 21, 2019
| /// - <xref:Microsoft.ML.Transforms.OneHotEncodingEstimator.OutputKind.Key> produces keys in a <xref:Microsoft.ML.Data.KeyDataViewType> column. | ||
| /// If the input column is a vector, the output contains a vectory [keys](xref:Microsoft.ML.Data.KeyDataViewType), where each slot of the | ||
| /// vector corresponds to the respective slot of the input vector. | ||
| /// If a category is not found in the bulit dictionary, it is assigned the value zero. |
There was a problem hiding this comment.
zero [](start = 85, length = 4)
suggest adding: which represents the key missing from the dictionary.
sfilipi
reviewed
Apr 21, 2019
glebuk
reviewed
Apr 21, 2019
| The mutual information of two random variables X and Y is a measure of the mutual dependence between the variables. | ||
| Formally, the mutual information can be written as: | ||
| </para> | ||
| <para>I(X;Y) = E[log(p(x,y)) - log(p(x)) - log(p(y))]</para> |
There was a problem hiding this comment.
Wasn't there a latex formula that Senja has created just recently for this? https://github.com/dotnet/machinelearning/pull/3448/files
There was a problem hiding this comment.
This isn't applicable to the categorical transforms
glebuk
approved these changes
Apr 21, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for Categorical transforms using template given in #3204 and implemented in #3316.