Add XML to LBFGS Maximum Entropy Classifier #3389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3389 +/- ##
==========================================
+ Coverage 72.69% 72.75% +0.05%
==========================================
Files 807 807
Lines 145172 145335 +163
Branches 16225 16232 +7
==========================================
+ Hits 105533 105733 +200
+ Misses 35223 35183 -40
- Partials 4416 4419 +3
|
wschin
commented
Apr 18, 2019
src/Microsoft.ML.StandardTrainers/Standard/LogisticRegression/MulticlassLogisticRegression.cs
Outdated
Show resolved
Hide resolved
…MulticlassLogisticRegression.cs
shmoradims
reviewed
Apr 19, 2019
|
|
||
| | Output Column Name | Column Type | Description| | ||
| | -- | -- | -- | | ||
| | `Score` | array of <xref:System.Single> | The scores of all classes. Higher value means higher probability to fall into the associated class. If the i-th element has the lagest value, the predicted label index would be i. Note that i is zero-based index. | |
There was a problem hiding this comment.
array [](start = 12, length = 5)
if it's a vbuffer, let's call it 'vector' instead. #Resolved
shmoradims
reviewed
Apr 19, 2019
|
|
||
| | Output Column Name | Column Type | Description| | ||
| | -- | -- | -- | | ||
| | `Score` | array of <xref:System.Single> | The scores of all classes. Higher value means higher probability to fall into the associated class. If the i-th element has the lagest value, the predicted label index would be i. Note that i is zero-based index. | |
There was a problem hiding this comment.
lagest [](start = 172, length = 6)
typo: largest
please use spell checker. we won't catch all the typos manually.
https://marketplace.visualstudio.com/items?itemName=EWoodruff.VisualStudioSpellChecker #Resolved
shmoradims
reviewed
Apr 19, 2019
src/Microsoft.ML.StandardTrainers/Standard/LogisticRegression/MulticlassLogisticRegression.cs
Show resolved
Hide resolved
singlis
reviewed
Apr 20, 2019
| @@ -521,8 +521,8 @@ public IClassificationLoss CreateComponent(IHostEnvironment env) | |||
| /// Predict a target using a linear binary classification model trained with the <see cref="Trainers.LbfgsLogisticRegressionBinaryTrainer"/> trainer. | |||
There was a problem hiding this comment.
[](start = 11, length = 2)
Create , which predicts a ... #Resolved
There was a problem hiding this comment.
This is binary classifier. I shouldn't touch it. Thanks!
In reply to: 277117848 [](ancestors = 277117848)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #2522 following #3218.