XML documentation for FastForest binary classification. #3399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmoradims
reviewed
Apr 18, 2019
shmoradims
reviewed
Apr 18, 2019
shmoradims
reviewed
Apr 18, 2019
shmoradims
reviewed
Apr 18, 2019
shmoradims
reviewed
Apr 19, 2019
| @@ -414,7 +414,7 @@ public static class TreeExtensions | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Predict a target using a decision tree regression model trained with the <see cref="FastForestBinaryTrainer"/> and advanced options. | |||
| /// Create <see cref="FastForestBinaryTrainer"/> with <see cref="FastForestBinaryTrainer.Options"/>, which predicts a target using a decision tree regression model. | |||
There was a problem hiding this comment.
[](start = 62, length = 45)
just say "with advanced options" to be consistent with the template #Closed
There was a problem hiding this comment.
natke
approved these changes
Apr 19, 2019
shmoradims
reviewed
Apr 19, 2019
| /// | ||
| /// [!include[io](~/../docs/samples/docs/api-reference/io-columns-binary-classification.md)] | ||
| /// | ||
| /// [!include[algorithm](~/../docs/samples/docs/api-reference/fastforest.md)] |
There was a problem hiding this comment.
fastforest [](start = 66, length = 10)
use 'algo-details-xxx' pattern. in this case 'algo-details-fastforest.md' #Resolved
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
==========================================
+ Coverage 72.69% 72.73% +0.03%
==========================================
Files 807 807
Lines 145172 145206 +34
Branches 16225 16230 +5
==========================================
+ Hits 105533 105613 +80
+ Misses 35223 35176 -47
- Partials 4416 4417 +1
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #2522