XML for MLContext.Model (root) #3451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P4 API, and we rarely use it even in our codebase. So we don't have samples for it.
Codecov Report
@@ Coverage Diff @@
## master #3451 +/- ##
==========================================
+ Coverage 72.76% 72.78% +0.01%
==========================================
Files 808 808
Lines 145452 145452
Branches 16244 16244
==========================================
+ Hits 105842 105866 +24
+ Misses 35189 35163 -26
- Partials 4421 4423 +2
|
natke
approved these changes
Apr 21, 2019
artidoro
reviewed
Apr 21, 2019
| @@ -317,6 +317,15 @@ public ITransformer LoadWithDataLoader(string filePath, out IDataLoader<IMultiSt | |||
| return transformer.CreatePredictionEngine<TSrc, TDst>(_env, ignoreMissingColumns, inputSchemaDefinition, outputSchemaDefinition); | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Create a prediction engine for one-time prediction. | |||
| /// It's mainly used in conjunction with <see cref="Load(Stream, out DataViewSchema)"/>, | |||
There was a problem hiding this comment.
It's [](start = 12, length = 4)
nit: This overload is generally used ...
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most APIs have been covered by Tom already. Just added the one missing one.