Skip to content

Reformat categorical transform samples. #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2019
Merged

Reformat categorical transform samples. #3588

merged 2 commits into from
Apr 30, 2019

Conversation

codemzs
Copy link
Member

@codemzs codemzs commented Apr 25, 2019

towards #3478

artidoro
artidoro approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@artidoro artidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

najeeb-kazmi
najeeb-kazmi approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@najeeb-kazmi najeeb-kazmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

glebuk
glebuk approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@glebuk glebuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codemzs codemzs merged commit 3712486 into dotnet:master Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019 •
edited
Loading

Codecov Report

Merging #3588 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
- Coverage   72.77%   72.76%   -0.01%     
==========================================
  Files         808      808              
  Lines      145470   145470              
  Branches    16244    16244              
==========================================
- Hits       105860   105856       -4     
- Misses      35190    35192       +2     
- Partials     4420     4422       +2
Flag Coverage Δ
#Debug 72.76% <ø> (-0.01%) ⬇️
#production 68.28% <ø> (-0.01%) ⬇️
#test 89.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/Microsoft.ML.Maml/MAML.cs 24.75% <0%> (-1.46%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 60.05% <0%> (-0.27%) ⬇️

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@najeeb-kazmi najeeb-kazmi najeeb-kazmi approved these changes

@shmoradims shmoradims shmoradims left review comments

@artidoro artidoro artidoro approved these changes

@glebuk glebuk glebuk approved these changes

@natke natke Awaiting requested review from natke

@sfilipi sfilipi Awaiting requested review from sfilipi

@eerhardt eerhardt Awaiting requested review from eerhardt

@TomFinley TomFinley Awaiting requested review from TomFinley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codemzs @artidoro @najeeb-kazmi @shmoradims @glebuk