Skip to content

Update error messages to point to GitHub issues instead of support group #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2018

Conversation

jwood803
Copy link
Contributor

Fix for issue #258 by replacing tlcsupp with a link to https://aka.ms/MLNetIssue.

Due to my lacking git skills, some commits from #358 got in, but I believe that can get cleaned up if/when it gets merged.

@dnfclas
Copy link

dnfclas commented Jun 14, 2018

CLA assistant check
All CLA requirements met.

@danmoseley
Copy link
Member

Hi @jwood803, you should be able to eliminate the extra changes by either rebasing your branch onto master, or merging master into your branch.

If you do the former (what I typically do) you will have to git push -f to update this PR, other wise you can just git push.

You're probably right that on merging, the changes should vanish, but if they do not entirely vanish, they are then committed to master, so it is best to have the PR look how you want it.

@jwood803
Copy link
Contributor Author

Thanks, @danmosemsft! I'll make sure to remember that for next time. 😄

Hopefully, the PR is as it should be.

@danmoseley
Copy link
Member

@jwood803 assuming you only wanted to make the comment changes, this didn't work, as they still show up: https://github.com/dotnet/machinelearning/pull/359/files

My instructions were mistaken, then. I think what is easiest is you just do git reset --hard master (this will lose all your changes, but keep you on the branch for this PR) then make the change manually, commit, and git push -f. Does that do it?

@jwood803
Copy link
Contributor Author

@danmosemsft Thanks a ton! I had to reset to upstream master, but I think I now got this correct! 😄 Thanks again for the help!

@shauheen
Copy link
Contributor

Thanks @jwood803 for this PR.

@shauheen shauheen self-requested a review June 26, 2018 13:32
@Ivanidzo4ka Ivanidzo4ka self-requested a review July 11, 2018 19:48
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @jwood803

@Ivanidzo4ka Ivanidzo4ka merged commit 9d9d74e into dotnet:master Jul 11, 2018
ChiragRupani pushed a commit to ChiragRupani/machinelearning that referenced this pull request Jul 12, 2018
*Update error messages to point to GitHub issues instead of support group
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
*Update error messages to point to GitHub issues instead of support group
@jwood803 jwood803 deleted the error-messages branch October 6, 2018 11:55
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants