-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update error messages to point to GitHub issues instead of support group #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @jwood803, you should be able to eliminate the extra changes by either rebasing your branch onto master, or merging master into your branch. If you do the former (what I typically do) you will have to You're probably right that on merging, the changes should vanish, but if they do not entirely vanish, they are then committed to master, so it is best to have the PR look how you want it. |
Thanks, @danmosemsft! I'll make sure to remember that for next time. 😄 Hopefully, the PR is as it should be. |
@jwood803 assuming you only wanted to make the comment changes, this didn't work, as they still show up: https://github.com/dotnet/machinelearning/pull/359/files My instructions were mistaken, then. I think what is easiest is you just do |
@danmosemsft Thanks a ton! I had to reset to upstream master, but I think I now got this correct! 😄 Thanks again for the help! |
Thanks @jwood803 for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR @jwood803
*Update error messages to point to GitHub issues instead of support group
*Update error messages to point to GitHub issues instead of support group
Fix for issue #258 by replacing
tlcsupp
with a link to https://aka.ms/MLNetIssue.Due to my lacking git skills, some commits from #358 got in, but I believe that can get cleaned up if/when it gets merged.