Skip to content

Fix the build badge link #4267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Fix the build badge link #4267

merged 1 commit into from
Oct 1, 2019

Conversation

frank-dong-ms-zz
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@frank-dong-ms-zz frank-dong-ms-zz requested a review from a team as a code owner September 30, 2019 21:18
@codemzs
Copy link
Member

codemzs commented Sep 30, 2019

I see two badges for each flavor see below:

image

codemzs
codemzs approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frank-dong-ms-zz
Copy link
Contributor Author

frank-dong-ms-zz commented Sep 30, 2019 •
edited
Loading

Fix the build badge link bug, thanks for review #Resolved

@harishsk harishsk merged commit f790a69 into dotnet:master Oct 1, 2019
@frank-dong-ms-zz frank-dong-ms-zz deleted the build-badge-bug branch April 15, 2020 20:37
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codemzs codemzs codemzs approved these changes

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frank-dong-ms-zz @codemzs @safern @harishsk @frank-dong-ms