Add Seasonality Detection #5200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #5200 +/- ##
==========================================
- Coverage 75.78% 73.22% -2.57%
==========================================
Files 993 1009 +16
Lines 180969 188212 +7243
Branches 19489 20282 +793
==========================================
+ Hits 137151 137812 +661
- Misses 38521 44873 +6352
- Partials 5297 5527 +230
|
harishsk
reviewed
Jun 10, 2020
| using System.Text; | ||
|
|
||
| namespace Microsoft.ML.TimeSeries | ||
| { |
There was a problem hiding this comment.
This PR doesn't integrate with any other code in ML.NET. How does this implement seasonality detection?
Can you please update it or close it if this is not going to be developed further?
There was a problem hiding this comment.
I will update it NLT tomorrow.
There was a problem hiding this comment.
Please review PR 5231 and I have asked the PR owner to abandon this PR.
|
Can we abandon this PR and replace it with PR 5231? |
|
Closing because this has been superseded by #5231 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.