-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Linux CI to actually run inside a docker container #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can now see that it initializes the container and stops it at the beginning and end of the Linux phases. |
queue: {} | ||
|
||
phases: | ||
- phase: ${{ parameters.name }} | ||
variables: | ||
_buildScript: ${{ parameters.buildScript }} | ||
_phaseName: ${{ parameters.name }} | ||
# if dockerImage is not equal to '' then run under docker container | ||
${{ if ne(parameters.dockerImage, '') }}: | ||
_PREVIEW_VSTS_DOCKER_IMAGE: ${{ parameters.dockerImage }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chcosta - do you have any idea how long we will need to continue using this "preview" feature in VSTS? And when a replacement will be possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm experimenting with using resources / containers in CI now (https://github.com/dotnet/arcade/pull/349/files). Clearly, I've been fighting the system. I'm also talking with VSTS folks as I encounter issues. I hope to have something working (or a definitive "this doesn't work") in the next day or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me with resources it didn't work. I tried adding the container image as the full name
microsoft/dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416
and I also tried spliting it:
image: dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416
endpoint: microsoft
and it didn't work. That is why I switched to the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ivanidzo4ka if you rebase your PR now, you should be able to run the tests 😄 |
@safern it's finally working! Thank you! |
Current CI was not running under a docker container. Use a different approach using a vsts variable to run under the container.
cc: @eerhardt @Ivanidzo4ka