Skip to content

Fix Linux CI to actually run inside a docker container #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

safern
Copy link
Member

@safern safern commented Jul 23, 2018

Current CI was not running under a docker container. Use a different approach using a vsts variable to run under the container.

cc: @eerhardt @Ivanidzo4ka

@safern
Copy link
Member Author

safern commented Jul 23, 2018

You can now see that it initializes the container and stops it at the beginning and end of the Linux phases.

queue: {}

phases:
- phase: ${{ parameters.name }}
variables:
_buildScript: ${{ parameters.buildScript }}
_phaseName: ${{ parameters.name }}
# if dockerImage is not equal to '' then run under docker container
${{ if ne(parameters.dockerImage, '') }}:
_PREVIEW_VSTS_DOCKER_IMAGE: ${{ parameters.dockerImage }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chcosta - do you have any idea how long we will need to continue using this "preview" feature in VSTS? And when a replacement will be possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm experimenting with using resources / containers in CI now (https://github.com/dotnet/arcade/pull/349/files). Clearly, I've been fighting the system. I'm also talking with VSTS folks as I encounter issues. I hope to have something working (or a definitive "this doesn't work") in the next day or so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me with resources it didn't work. I tried adding the container image as the full name
microsoft/dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416

and I also tried spliting it:

image: dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416
endpoint: microsoft

and it didn't work. That is why I switched to the variable.

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@safern safern merged commit e885b73 into dotnet:master Jul 23, 2018
@safern safern deleted the FixLinuxCi branch July 23, 2018 21:45
@safern
Copy link
Member Author

safern commented Jul 23, 2018

@Ivanidzo4ka if you rebase your PR now, you should be able to run the tests 😄

@Ivanidzo4ka
Copy link
Contributor

@safern it's finally working! Thank you!

eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
codemzs pushed a commit to codemzs/machinelearning that referenced this pull request Aug 1, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants