-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Expose the Onnx runtime option for setting the number of threads #5962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce0e6c3
Expose number of threads option of OnnxRuntime
yaeldMS 5769de7
Merge from main branch
yaeldMS 51d03f8
Create new overload that contains interopNumThreads/intraopNumThreads…
yaeldMS f81a9ac
Add OnnxOptions class
yaeldMS f684cc6
Add test.
yaeldMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Collections.Generic; | ||
|
||
namespace Microsoft.ML.Transforms.Onnx | ||
{ | ||
/// <summary> | ||
/// The options for an <see cref="OnnxScoringEstimator"/>. | ||
/// </summary> | ||
public sealed class OnnxOptions | ||
{ | ||
/// <summary> | ||
/// Path to the onnx model file. | ||
/// </summary> | ||
public string ModelFile; | ||
|
||
/// <summary> | ||
/// Name of the input column. | ||
/// </summary> | ||
public string[] InputColumns; | ||
|
||
/// <summary> | ||
/// Name of the output column. | ||
/// </summary> | ||
public string[] OutputColumns; | ||
|
||
/// <summary> | ||
/// GPU device id to run on (e.g. 0,1,..). Null for CPU. Requires CUDA 9.1. | ||
/// </summary> | ||
public int? GpuDeviceId = null; | ||
|
||
/// <summary> | ||
/// If true, resumes execution on CPU upon GPU error. If false, will raise the GPU exception. | ||
/// </summary> | ||
public bool FallbackToCpu = false; | ||
|
||
/// <summary> | ||
/// ONNX shapes to be used over those loaded from <see cref="ModelFile"/>. | ||
/// </summary> | ||
public IDictionary<string, int[]> ShapeDictionary; | ||
|
||
/// <summary> | ||
/// Protobuf CodedInputStream recursion limit. | ||
/// </summary> | ||
public int RecursionLimit = 100; | ||
|
||
/// <summary> | ||
/// Controls the number of threads used to parallelize the execution of the graph (across nodes). | ||
/// </summary> | ||
public int? InterOpNumThreads = null; | ||
|
||
/// <summary> | ||
/// Controls the number of threads to use to run the model. | ||
/// </summary> | ||
public int? IntraOpNumThreads = null; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the API compat is failing. You will need either need to make a new method here, or make an onnx options class that encapsulates these.
@eerhardt do you think an onnx options class would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1798. The established pattern is:
And if (1) is sufficient, we can opt out of (2).
So, yes, I believe the new options should force us to create the Options class here.