Skip to content

Add needed param to warning for L2 in SDCA #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 30, 2018
Merged

Add needed param to warning for L2 in SDCA #597

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f03189d
Merge pull request #1 from dotnet/master
justinormont Jun 4, 2018
1421743
Merge pull request #2 from dotnet/master
justinormont Jun 12, 2018
24d939a
Merge pull request #3 from dotnet/master
justinormont Jul 29, 2018
3258e37
Fix warning for L2 in SDCA
justinormont Jul 29, 2018
dc42fee
String interpolation
justinormont Jul 30, 2018
4da3c50
Word-smithing the warning message
justinormont Jul 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ internal virtual void Check(IHostEnvironment env)
{
ch.Warning("The specified l2Const = {0} is too small. SDCA optimizes the dual objective function. " +
"The dual formulation is only valid with a positive L2 regularization. Also, an l2Const less than {1} " +
"could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const);
"could drastically slow down the convergence. So using l2Const = {1} instead.", L2Const, L2LowerBound);
Copy link
Contributor

@TomFinley TomFinley Jul 29, 2018 •
edited by justinormont
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l2Const [](start = 83, length = 7)

Hi @justinormont thanks for looking at this. Another problem with this message, replace these with nameof(L2Const), here, and everywhere in this message that it is used, in the format args. It might go easier if you used the $ string interpolation. #resolved


L2Const = L2LowerBound;
ch.Done();
Expand Down Expand Up @@ -1752,4 +1752,4 @@ public static CommonOutputs.BinaryClassificationOutput TrainBinary(IHostEnvironm

}
}
}
}