support validation and incremental trainers #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
approved these changes
Jul 30, 2018
There was a problem hiding this comment.
Whoops... thanks @Ivanidzo4ka, for cleaning up my mess. This is a fix of oversights in #522.
codemzs
pushed a commit
to codemzs/machinelearning
that referenced
this pull request
Aug 1, 2018
add proper fields to trainer info for FT, FM, and OnlineLearner regarding incremental training and validation datasets
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal test shows what some trainers stop properly handle validation datasets and continue training.
Thus I'm trying to set proper flags in Info, although, it feels like this flags are useless, but what do I know.