Added Microsoft.ML.Benchmarks Project #62
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <LangVersion>7.2</LangVersion> | ||
| <TargetFramework>net472</TargetFramework> | ||
|
There was a problem hiding this comment. Is there a reason this doesn't target .NET Core or .NET Standard? There was a problem hiding this comment. It's an exe, so it cannot be .NET Standard (which is for dlls). It could be .NET Core app, but NetFx app makes it easier to run it, as the project output is an exe. There was a problem hiding this comment. Still, the dependency of .NET 4.7 makes this code unrunable on Linux, right? Can't we make it dual-target? There was a problem hiding this comment. Makes sense. I will change the host app to .NET Core too. |
||
| <Platforms>x64</Platforms> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="BenchmarkDotNet" Version="0.10.14" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Microsoft.ML.StandardLearners\Microsoft.ML.StandardLearners.csproj" /> | ||
| <ProjectReference Include="..\..\src\Microsoft.ML\Microsoft.ML.csproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <NativeAssemblyReference Include="CpuMathNative" /> | ||
| </ItemGroup> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using BenchmarkDotNet.Configs; | ||
| using BenchmarkDotNet.Diagnosers; | ||
| using BenchmarkDotNet.Jobs; | ||
| using BenchmarkDotNet.Running; | ||
| using System.IO; | ||
|
|
||
| namespace Microsoft.ML.Benchmarks | ||
| { | ||
| public class Program | ||
| { | ||
| /// <summary> | ||
| /// execute dotnet run -c Release and choose the benchmarks you want to run | ||
| /// </summary> | ||
| /// <param name="args"></param> | ||
| public static void Main(string[] args) | ||
| { | ||
| BenchmarkSwitcher | ||
| .FromAssembly(typeof(Program).Assembly) | ||
| .Run(null, CreateClrVsCoreConfig()); | ||
| } | ||
|
|
||
| private static IConfig CreateClrVsCoreConfig() | ||
| { | ||
| var config = DefaultConfig.Instance.With( | ||
| Job.ShortRun. | ||
| With(BenchmarkDotNet.Environments.Platform.X64)). | ||
| With(MemoryDiagnoser.Default); | ||
| return config; | ||
| } | ||
|
|
||
| internal static string GetDataPath(string name) | ||
| => Path.GetFullPath(Path.Combine(_dataRoot, name)); | ||
|
|
||
| static readonly string _dataRoot; | ||
| static Program() | ||
| { | ||
| var currentAssemblyLocation = new FileInfo(typeof(Program).Assembly.Location); | ||
| var rootDir = currentAssemblyLocation.Directory.Parent.Parent.Parent.Parent.FullName; | ||
| _dataRoot = Path.Combine(rootDir, "test", "data"); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we mark the
.slnas binary? Merging it is usually hopeless anyway :) #ClosedUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eerhardt/@danmosemsft, any opinions on this? #Closed
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible to merge
.slnfiles. They are rather touchy though - white space is actually important.We don't do this in any other repo that I'm aware of. And it is always good to be able to read/review the .sln file edits. So unless we have a compelling reason to make this change, I'd vote we keep it as-is. #Closed
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text works ok in other repos. #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SLN is a text file. A messy one perhaps. It has been merged as a text file for at least 10 years. On few occasions it was quite useful to see the text. With proper training it is quite mergeable
In reply to: 186587605 [](ancestors = 186587605)