Skip to content

Fix test output during CI. #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Aug 6, 2018

When tests run in CI, we are not displaying the test output to the console. So if a test fails, and for some reason the .trx file isn't parsed correctly, it is impossible to see what test failed and why.

The test output isn't being displayed because of microsoft/vstest#1503.

To work around the vstest bug, split CI builds into 2 separate MSBuild invocations: one to do the build (which is multi-proc) and another to run the tests (which doesn't need MSBuild node reuse).

When tests run in CI, we are not displaying the test output to the console. So if a test fails, and for some reason the .trx file isn't parsed correctly, it is impossible to see what test failed and why.

The test output isn't being displayed because of microsoft/vstest#1503.

To work around the vstest bug, split CI builds into 2 separate MSBuild invocations: one to do the build (which is multi-proc) and another to run the tests (which doesn't need MSBuild node reuse).
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eerhardt eerhardt merged commit f9d3973 into dotnet:master Aug 6, 2018
@eerhardt eerhardt deleted the FixTestOutput branch August 6, 2018 20:03
@Ivanidzo4ka
Copy link
Contributor

Both OSX builds are red, is it expected?

@eerhardt
Copy link
Member Author

eerhardt commented Aug 6, 2018

Yes - because the netci.groovy file has changed. New changes to the netci.groovy file don't take affect until you merge the PR.

The good thing to know is that @safern is going to switch OSX over to the VSTS public CI, now that we have mac machines available. So we won't have this issue anymore going forward.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants