Skip to content

Add TensorFlow documentation to the main class, and include examples on it. #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 11, 2018

Conversation

sfilipi
Copy link
Member

@sfilipi sfilipi commented Sep 8, 2018

Fixes #866
Adds the documentation to the class, and not just the Create method, and changes the visibility of some of the properties that don't need to be user-facing.

Includes the examples in the doc.

…he Microsoft.ML.Transforms namespace, and get picked up by the documentation
Removing the reference from the CsharpApi, since the transform is already created in the right namespace: Microsoft.ML.Transforms.

Changing the visibility of the Summary, UserName and ShortName to internal.
…nce it will appear in the Microsoft.ML.Transforms namespace.
adding the <include> to the class post-merge.
@sfilipi sfilipi self-assigned this Sep 8, 2018
@sfilipi sfilipi added the documentation Related to documentation of ML.NET label Sep 8, 2018
@@ -4,7 +4,7 @@

<member name="TensorflowTransform">
<summary>
Extracts hidden layers' values from a pre-trained Tensorflow model.
Extracts hidden layers&apos; values from a pre-trained Tensorflow model.
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka Sep 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

' [](start = 30, length = 6)

is it even necessary? #Pending

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML requires to escap: ', ", <, >, & characters.

To my surprise, this was displaying fine, but i have had trouble with the rest of them. Changed it for consistency.


In reply to: 216144446 [](ancestors = 216144446)

Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

/// Transforms the data using the TensorFlow model.
/// </summary>
/// <include file='../Microsoft.ML.TensorFlow/doc.xml' path='doc/members/member[@name="TensorflowTransform"]/*' />
/// <include file='../Microsoft.ML.TensorFlow/doc.xml' path='doc/members/example[@name="TensorflowTransform"]/*' />
Copy link
Contributor

@zeahmed zeahmed Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'doc/members/example [](start = 68, length = 20)

I see that example tag is under member tag. It's not immediately under members. Will it work?

My understanding is that if we are doing
/// <include file='../Microsoft.ML.TensorFlow/doc.xml' path='doc/members/member[@name="TensorflowTransform"]/*' />

Everything including example will also be copied here. #Resolved

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Zeeshan.


In reply to: 216475085 [](ancestors = 216475085)

});

pipeline.Add(new ImageResizer((&quot;ImageReal&quot;, &quot;ImageCropped&quot;))
pipeline.Add(new ImageResizer(("ImageReal", "ImageCropped"))
Copy link
Member Author

@sfilipi sfilipi Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" [](start = 54, length = 1)

Turns out that " in the sections are ok, but not the <, > characters. Converted them to make the example more readable. #Resolved

Copy link
Contributor

@zeahmed zeahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi sfilipi merged commit 52aff02 into dotnet:master Sep 11, 2018
@sfilipi sfilipi deleted the tensorflowDocWiring branch September 11, 2018 23:21
@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Related to documentation of ML.NET
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants