Term estimators in static pipeline #870
Conversation
| @@ -327,5 +327,43 @@ public void NormalizerWithOnFit() | |||
| Console.WriteLine(Encoding.UTF8.GetString(stream.ToArray())); | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void ToKey() | |||
There was a problem hiding this comment.
ToKey [](start = 20, length = 5)
Do you keep insisting that all the pigsty testing is done in this file?
There was a problem hiding this comment.
No, not insisting, it is just useful to me for this to be the case since as far as I see visual studio lost the ability to group tests by anything other than the class, and I am often wanting to run all pigsty using tests (to ensure that when I change the infrastructure I don't break things). I would be more enthusiastic about putting the tests somewhere esle if there was some mechanism to select all tests of a given category, which regrettably I do not see is possible.
In reply to: 216414931 [](ancestors = 216414931)
There was a problem hiding this comment.
This may be something we want to bring up -- we used to have tests categories pretty well lined up across the different things you might want to test -- but now that mechanism seems to be gone, at least from the VS UI...
In reply to: 216490385 [](ancestors = 216490385,216414931)
| public delegate void OnFit(ToKeyFitResult<T> result); | ||
|
|
||
| // At the moment this is empty. Once PR #863 clears, we can change this class to hold the output | ||
| // key-values metadata. |
There was a problem hiding this comment.
Can we have issue about it?
ghost
locked as resolved and limited conversation to collaborators
Potentially controversial moves:
TermEstimatorasToKey, pursuant to There are two transforms with the Friendly Name "Term Transform" #214 discussion. Please consider discussing that there..ttfile to generate the extension methods. We've previously never used T4, but in this case I felt it was warranted.At the moment, #863 is not yet in, so the
onFitdelegate returns an object with nothing in it. If that goes in prior to when we must finish this work I'll update it, otherwise we'll do it later.