Concat estimator with pigsty extensions for ConcatWith, AsVector #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomFinley
commented
Sep 11, 2018
| // REVIEW: Note that the presence of this thing is a temporary measure only. | ||
| // If it is cleaned up by code complete so much the better, but if not we will | ||
| // have to wait a little bit. | ||
| internal sealed class ConcatTransformer : ITransformer, ICanSaveModel |
There was a problem hiding this comment.
Can we have issue, so this wouldn't be buried inside code?
In reply to: 216526746 [](ancestors = 216526746)
There was a problem hiding this comment.
I'm already working on concat transformer
In reply to: 216746880 [](ancestors = 216746880,216526746)
There was a problem hiding this comment.
I can confirm this, @Zruty0 will clean up my mess. 😃
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of the ConcatEstimator. It is functional but will require future work in future especially w.r.t. its transformer. Related to #632.