Skip to content

Bump Razor to 9.0.0-preview.25125.9 #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

davidwengier
Copy link
Member

View Complete Diff of Changes

@phil-allen-msft @ryzngard this build doesn't pass symbol check, but I'm working on the assumption that the diagnostics fix is more important, and that the C# extension build pipeline won't complain, but please confirm whether that's the way to go, or if we should wait for the symbol issue to be solved.

@davidwengier davidwengier requested a review from a team as a code owner February 27, 2025 02:39
@dibarbet dibarbet merged commit 085c84b into dotnet:main Feb 27, 2025
24 checks passed
@dibarbet
Copy link
Member

/backport to prerelease

Copy link
Contributor

Started backporting to prerelease: https://github.com/dotnet/vscode-csharp/actions/runs/13573581185

Copy link
Contributor

@dibarbet backporting to "prerelease" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Bump Razor to 9.0.0-preview.25125.9
Applying: Update changelog
Using index info to reconstruct a base tree...
M	CHANGELOG.md
Falling back to patching base and 3-way merge...
Auto-merging CHANGELOG.md
CONFLICT (content): Merge conflict in CHANGELOG.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Update changelog
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

dibarbet added a commit to dibarbet/vscode-csharp that referenced this pull request Feb 27, 2025
@davidwengier
Copy link
Member Author

I will take that as a yes :)

thanks for all your work @dibarbet !

@davidwengier davidwengier deleted the BumpRazor branch February 27, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants