Update Roslyn version to 5.0.0-1.25204.1 #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Apr 4, 2025
| @@ -4,7 +4,11 @@ | |||
| - Debug from .csproj and .sln [#5876](https://github.com/dotnet/vscode-csharp/issues/5876) | |||
|
|
|||
| # 2.73.x | |||
| * Bump Roslyn to 5.0.0-1.25204.1 (PR: [#8138](https://github.com/dotnet/vscode-csharp/pull/8138)) | |||
| * [View Complete Diff of Changes](https://github.com/dotnet/roslyn/compare/1a06295e3cd3e57be2c79953f16db724db119a4f...ad1c386da419e0d6fe9f25a1f41e5cc2368964e7?w=1) | |||
There was a problem hiding this comment.
the roslyn-analyzers merge is flooding the git history and making the changelog tool barf. For now just linking the full diff.
ryzngard
approved these changes
Apr 4, 2025
ryzngard
reviewed
Apr 4, 2025
| @@ -108,6 +109,7 @@ describe(`Formatting Tests`, () => { | |||
| 'using System;', | |||
| 'using Options;', | |||
| 'namespace Formatting;', | |||
| '', | |||
There was a problem hiding this comment.
🥳 the formatter not adding a new line has been a pain point for a while. Glad it's fixed!
There was a problem hiding this comment.
Thanks @Inurias ! I can't think of anything immediate. This usually hit me in VS when creating a new file. It would add the namespace, file header, etc but the formatting would be wrong for file scoped namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.