Support Html requests in cohosting #8210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Apr 24, 2025
| ) { | ||
| const logNotificationType = new NotificationType<LogMessageParams>('razor/log'); | ||
| languageServer.registerOnNotificationWithParams(logNotificationType, (params) => | ||
| razorLogger.log(params.message, params.type) | ||
| ); | ||
|
|
||
| if (!razorOptions.cohostingEnabled) { |
There was a problem hiding this comment.
Do we need to remove registration of dynamicFile endpoints if cohosting is on?
There was a problem hiding this comment.
Yeah, I think so. I think we never call them (though tbh I've put almost no effort into initialization yet)
There was a problem hiding this comment.
can be another pr for sure
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Apr 25, 2025
Part of #11759 Razor side of dotnet/vscode-csharp#8210 This PR does the infra for html requests in cohosting, and ports document color as the first test case. It's extremely simple after the re-layering PR from the other day :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/razor#11759
This is the guts of how html requests work in cohosting. Relatively simple, most of the work is now on the server. Also adds support for document color and color presentation as the first two test candidates.