Feat: Logic to show placeholder on inputs conditionally. #46
Conversation
| @@ -16,6 +16,8 @@ type Props = { | |||
| containerClassName?: string; | |||
| inputClassName?: string; | |||
| isPassword?: boolean; | |||
| placeholderCharacter?: string & { length: 1 }; | |||
| showPlaceholder: false; | |||
There was a problem hiding this comment.
I think we can handle the display of the placeholder using the placeholderCharacter prop, or do you see any case where we pass it and don't want to display it? Also, I would rename the prop to only placeholder
There was a problem hiding this comment.
Hello @drac94, if I tell you the idea of managing the "show Placeholder" variable to hide and show the placeholder is born from the need of the client, some companies manage that their input forms have a mask while others prefer that they remain without a mask , so the idea is that the package allows to do that configuration in a quite simple way, I don't know if I made myself understood hehe
There was a problem hiding this comment.
Regarding the name of the variable, if it is true, it is a better placeholder, the one that locates it is too verbose
There was a problem hiding this comment.
I think I understand the motivation for this feature and I can see how it is valuable, but in terms of implementation, we can just have a placeholder prop and nothing else, if it is set, we show the placeholder otherwise we don't. Basically this:
type Props = {
allowedCharacters?: typeof allowedCharactersValues[number];
...
placeholder?: string & { length: 1 };
}
...
<input
...
placeholder={placeholder}
/>
|
Hi @francmarin98, thanks for submitting the PR, I left a comment there |
|
Changes applied in #49 |
The goal of this pull request is mostly to support what a dynamic placeholder is. By default it would be '0' in my implementation, but of course you can choose another character by default.
One of my motivations was what @hailwood mentioned
in issue #43