-
Notifications
You must be signed in to change notification settings - Fork 937
Installation: "8.x-dev" and "--stability dev" redundant? #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hansfn
added a commit
to hansfn/drupal-project
that referenced
this issue
Jan 24, 2019
Merged
webflo
pushed a commit
that referenced
this issue
Jan 26, 2019
jcnventura
pushed a commit
that referenced
this issue
Mar 12, 2019
whikloj
pushed a commit
to islandora-deprecated/drupal-project
that referenced
this issue
May 24, 2019
* Honor .env files and suggest usage (drupal-composer#351) * Remove extra whitespace (drupal-composer#371) * Updated argument name * Bump minimal version * Bump minimal version to 8.5.3 * Fix installer path for drush commandfiles. * Update drupal-composer/drupal-scaffold drupal-composer/drupal-scaffold is a full featured plugin and provides its own command. * Fix tests on Travis CI (drupal-composer#405) * Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404) * Remove "drupal-scaffold" from scripts (drupal-composer#275) * Fix typo in README.md * Remove unused use statement. (drupal-composer#406) * Adjust default core patch level to -p2. (drupal-composer#418) * Bump minimum required composer-patches version to support default patch level (drupal-composer#410) * Update composer.json to require latest stable version of Drupal (drupal-composer#424) * Require zaporylie/composer-drupal-optimizations (drupal-composer#442) * Issue drupal-composer#408: Bump minimum PHP version to 5.6 * Removing redundant "--stability dev" from installation command (drupal-composer#450) Fixes drupal-composer#449. * Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420) * Sync new lines at the end of the files (drupal-composer#453) * Quote wildcards to avoid issues in some shells (drupal-composer#456) * Add PHP 7.3 to Travis CI (drupal-composer#476) * Change createRequiredFiles messages to reflect what occured (drupal-composer#467) * Drop PHP 5.6 testing (drupal-composer#489) * Bump minimum version to 8.7.0 (drupal-composer#488) * Update .travis.yml * update composer.lock
dannylamb
pushed a commit
to islandora-deprecated/drupal-project
that referenced
this issue
Jan 2, 2020
* Honor .env files and suggest usage (drupal-composer#351) * Remove extra whitespace (drupal-composer#371) * Updated argument name * Bump minimal version * Bump minimal version to 8.5.3 * Fix installer path for drush commandfiles. * Update drupal-composer/drupal-scaffold drupal-composer/drupal-scaffold is a full featured plugin and provides its own command. * Fix tests on Travis CI (drupal-composer#405) * Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404) * Remove "drupal-scaffold" from scripts (drupal-composer#275) * Fix typo in README.md * Remove unused use statement. (drupal-composer#406) * Adjust default core patch level to -p2. (drupal-composer#418) * Bump minimum required composer-patches version to support default patch level (drupal-composer#410) * Update composer.json to require latest stable version of Drupal (drupal-composer#424) * Require zaporylie/composer-drupal-optimizations (drupal-composer#442) * Issue drupal-composer#408: Bump minimum PHP version to 5.6 * Removing redundant "--stability dev" from installation command (drupal-composer#450) Fixes drupal-composer#449. * Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420) * Sync new lines at the end of the files (drupal-composer#453) * Quote wildcards to avoid issues in some shells (drupal-composer#456) * Add PHP 7.3 to Travis CI (drupal-composer#476) * Change createRequiredFiles messages to reflect what occured (drupal-composer#467) * Drop PHP 5.6 testing (drupal-composer#489) * Bump minimum version to 8.7.0 (drupal-composer#488) * Update .travis.yml * Deprecate PHP 7.0 and 7.1 (drupal-composer#518) * Revert "Deprecate PHP 7.1" (drupal-composer#521) This reverts commit 5085410. * Issue drupal-composer#518: Bump minimum php version to 7.0.8 * Update CI to Ubuntu 18.04 (drupal-composer#520) * Revert "Update CI to Ubuntu 18.04" (drupal-composer#526) This reverts commit ee5bf36. * Add 'contrib' to Drush commandfile installer path (drupal-composer#525) * Prefer usage of && operator instead of "and" (drupal-composer#530) * update to drupal 8.8.0 * replace webflo/drupal-core-require-dev with drupal/core-dev * Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522) * Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY * update to 8.8.1 Co-authored-by: Moshe Weitzman <[email protected]> Co-authored-by: Jakub Piasecki <[email protected]> Co-authored-by: Markus Orenstrat <[email protected]> Co-authored-by: Florian Weber <[email protected]> Co-authored-by: Rodrigo <[email protected]> Co-authored-by: Norman Kämper-Leymann <[email protected]> Co-authored-by: Alex Milkovskyi <[email protected]> Co-authored-by: Dezső BICZÓ <[email protected]> Co-authored-by: Matthew Grasmick <[email protected]> Co-authored-by: Andy Postnikov <[email protected]> Co-authored-by: Hans Fredrik Nordhaug <[email protected]> Co-authored-by: Maarten Segers <[email protected]> Co-authored-by: Peter Kokot <[email protected]> Co-authored-by: Simon Perdrisat <[email protected]> Co-authored-by: Charles Tanton <[email protected]> Co-authored-by: Greg Anderson <[email protected]> Co-authored-by: Paul <[email protected]>
shrop
pushed a commit
to shrop/drupal-project
that referenced
this issue
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The project page/readme gives the following installation command:
AFAIK know
--stability dev
is redundant when a dev version is selected (asdrupal-composer/drupal-project:8.x-dev
). Redundancy is bad because it's confusing (for people trying to understand the command/Composer) and it makes the command unnecessary long.I would have created a PR removing
--stability dev
but since very competent Composer people must have written the readme, I thought there is some reason for keeping it in after all ....The text was updated successfully, but these errors were encountered: