Skip to content

Remove files that are specific to drupal-project after create project #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jcnventura
Copy link
Collaborator

This patch returns the post-create-project step that was added in PR #7 to the 8.x branch. There's no need to keep the LICENSE and README.txt files. The phpunit.xml.dist and .travis.yml are used only for the project testing and should also be removed.

@jcnventura jcnventura force-pushed the jcnventura-remove-project-files branch from 1e8bc04 to 11adb91 Compare October 10, 2017 14:33
@fafnirical
Copy link

fafnirical commented Oct 11, 2017

rm is not cross-platform -- it doesn't exist on Windows, among possibly other environments. If this does get implemented, it should probably be implemented as a cross-platform PHP script.

@pfrenssen
Copy link
Collaborator

Good idea. I think we can even replace the existing Travis and PHPUnit manifests with files that will actually test the project itself rather than drupal-project. I have these in my fork.

@jcnventura
Copy link
Collaborator Author

jcnventura commented Oct 13, 2017

Well, rm is POSIX.. Most environments that provide a minimum operating system should have rm available.. Of course, Micro$oft being who they are, had to not comply with any standard that they didn't create themselves. But yes, a PHP script would be the way to go.

@jcnventura
Copy link
Collaborator Author

@pfrenssen Testing more than the project seems an interesting objective. But I wonder what the design goal should be in this project. I'd rather keep it simple and composer-centered, then to put all the bells and whistles, which require maintenance.

@jcnventura jcnventura force-pushed the jcnventura-remove-project-files branch from 11adb91 to 3a61c59 Compare October 13, 2017 12:35
@jcnventura
Copy link
Collaborator Author

Updated the code with a PHP-based script instead of using 'rm'..

I've replaced the commit to facilitate a merge.

@pfrenssen
Copy link
Collaborator

I'd rather keep it simple and composer-centered, then to put all the bells and whistles, which require maintenance.

Yeah that's the idea. I keep all the bells and whistles in my fork.

But I'm thinking that we can probably move some things like automated testing into the main repo now that we support Drush 9 which depends on robo. Robo is a task runner that can accomplish a lot of stuff.

@jcnventura jcnventura requested a review from webflo April 5, 2018 08:20
@jcnventura jcnventura force-pushed the jcnventura-remove-project-files branch from 3a61c59 to 3a9f0a3 Compare April 12, 2018 19:29
@webflo webflo mentioned this pull request Apr 13, 2018
@jcnventura jcnventura force-pushed the jcnventura-remove-project-files branch from 3a9f0a3 to 231ec4d Compare August 27, 2019 09:16
@jcnventura jcnventura closed this Apr 19, 2021
@jcnventura jcnventura deleted the jcnventura-remove-project-files branch April 19, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants