Add mypy-plugin extra dependency #1605
Conversation
There was a problem hiding this comment.
I would prefer this name: https://github.com/typeddjango/django-stubs#installation
zhukovgreen
force-pushed
the
add-mypy-plugin-extras
branch
from
22bf87d to
f4d0905
Compare
|
Should be fine now |
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 79 79
Lines 2494 2494
Branches 434 158 -276
==========================================
Hits 2494 2494 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Need some help here with the failure on py37. Vry probable that this failure is not related to the merge request |
pyproject.toml
Outdated
| @@ -48,6 +48,7 @@ _ = "returns.contrib.hypothesis._entrypoint" | |||
| python = "^3.7" | |||
|
|
|||
| typing-extensions = ">=4.0,<5.0" | |||
| mypy = { version = "^1.2", optional = true } | |||
There was a problem hiding this comment.
I think we can now remove mypy from dev-dependencies
There was a problem hiding this comment.
Why do you think so? In this case, poetry install won't install mypy.
There was a problem hiding this comment.
if we remove the mypy from the dev-dependencies, then in order to let the mypy installed, we need to do:
$ poetry install --extras compatible-mypyOtherwise mypy won't be installed. If we have the mypy of the same version in the dev dependencies, then poetry install will install it (because dev deps are included when poetry install).
There was a problem hiding this comment.
zhukovgreen
force-pushed
the
add-mypy-plugin-extras
branch
from
f4d0905 to
1c77547
Compare
zhukovgreen
force-pushed
the
add-mypy-plugin-extras
branch
4 times, most recently
from
e4881d1 to
ca4548b
Compare
zhukovgreen
force-pushed
the
add-mypy-plugin-extras
branch
2 times, most recently
from
1ec2722 to
df7170a
Compare
use `pip install classes[mypy-plugin]` for installin additional dependencies required by the mypy-plugin. Add mypy-plugin extra dependency use `pip install classes[mypy-plugin]` for installing additional dependencies required by the mypy-plugin.
zhukovgreen
force-pushed
the
add-mypy-plugin-extras
branch
from
df7170a to
3b905ef
Compare
|
@sobolevn seems like all done now |
use
pip install classes[compatible-mypy]for installing additional dependencies required by the mypy-plugin.I have made things!
Checklist
CHANGELOG.mdRelated issues
🙏 Please, if you or your company finds
dry-pythonvaluable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.