[Feat] Add --create-issue character limit check #491
Merged
+69
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ds300 , a PR review would be appreciated :) |
|
Hey @ds300 , any update on this feature? |
|
Hey @ds300, are there any other maintainers who could take a look? Communication seems to have been suddenly cut off. Are you still present? |
|
@ds300 Hey so im cleaning my PRs I'm contributing around, any chance this can be reviewed again/merged to incorporate this feature in a new release? There hasn't been any new releases in a year |
|
hey @orta any chance you could review this PR, please? |
|
I think this is a good idea, lets have it in |
|
Thanks so much @orta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #328
This change adds a limit to the message sent to the GitHub create issue URL to avoid URL too long errors.
If the diff contents exceed 300 characters (this was chosen arbitrarily), the diff contents are replaced with a comment message replacement, and the console outputs the complete PR diff contents and instructs the user to copy/paste the diff into the PR description manually.
(The old PR was closed automatically when I merged the OG repo into the forked repo)