Update gitignore implementation to support more cases #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
May 26, 2025
| @@ -2,13 +2,17 @@ | |||
| from pathlib import Path | |||
| from typing import BinaryIO, Optional | |||
|
|
|||
| import humanize | |||
colinjc
force-pushed
the
cc/05-23-update_gitignore_implementation_to_support_more_cases
branch
from
ec926a5 to
de4bbf1
Compare
colinjc
force-pushed
the
cc/05-23-update_gitignore_implementation_to_support_more_cases
branch
from
de4bbf1 to
d7fa66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was missing support for a ** which was pretty critical. This updates the logic to use an existing library which already supports **.