Remove unneeded intermediate async for Ethernet #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the always pending worker whose job it was to fire another async worker after a timeout.
earlephilhower
added a commit
that referenced
this pull request
Feb 1, 2024
Fixes #1973 The periodic LWIP pump/Ethernet packet reader async_context stopped firing occasionally under high packet loads, causing the LWIP stack to become unresponsive to any incoming data. Re-implement the 2-step process for polling (like the CYW43 driver from the RPI folks does) and undoes #1864 change.
earlephilhower
added a commit
that referenced
this pull request
Feb 1, 2024
Fixes #1973 The periodic LWIP pump/Ethernet packet reader async_context stopped firing occasionally under high packet loads, causing the LWIP stack to become unresponsive to any incoming data. Re-implement the 2-step process for polling (like the CYW43 driver from the RPI folks does) and undoes #1864 change.
earlephilhower
added a commit
that referenced
this pull request
Feb 2, 2024
Fixes #1973 The periodic LWIP pump/Ethernet packet reader async_context stopped firing occasionally under high packet loads, causing the LWIP stack to become unresponsive to any incoming data. Re-implement the 2-step process for polling (like the CYW43 driver from the RPI folks does) and undoes #1864 change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the always pending worker whose job it was to fire another async worker after a timeout.