This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Test loadtest API against our OpenAPI doc #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Waller <[email protected]>
rwalle61
force-pushed
the
test-loadtest-api-against-doc
branch
from
9257de8 to
1a82f89
Compare
|
@rwalle61 Could you merge this PR if there's no pending change coming? Too many builds for a single PR would affect Jenkins performance. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Waller [email protected]
Similar to #203 and #205, this uses our Chai OpenAPI response validator plugin to automatically test that PFE responds as our OpenAPI doc claims it does.
Discovered and corrected minor mistakes in PFE and our doc. In PFE, we had forgotten to set the
application/jsonheader for the200response toPOST /api/v1/projects/{id}/loadtest/config. Correspondingly, we had also forgot to specify a response body in our doc.