Merge Develop into Master for Eclipse Photon 1.1.0 release #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed reference to window and change to self Removed reference to window and change to self. This is to allow the client to be used in Web Workers see: https://developer.mozilla.org/en/docs/Web/API/Window/self Signed-off-by: Tadhg Mulkern<[email protected]> * Updated Client-hareness.js Updated Client-hareness.js, set global.window = global; to global.self = global; * Update .travis.yml to fix build error Update .travis.yml to fix build error, set nodejs version to use the latest stable version of 5.x
* Refactored Properties using Object.defineProperties Refactored Properties using Object.defineProperties as seen here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperties This reduces the javascript code by removing repeated code. This will have a impact on overall file size. Signed-off-by: Tadhg Mulkern<[email protected]> * Added additional cleanup of code Added a piece of code to removed the need for all the Typed Array checks, base on this method https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView and from the Stackoverflow answer https://stackoverflow.com/questions/15251879/how-to-check-if-a-variable-is-a-typed-array-in-javascript/29651223#29651223
Changed usages of push on this._buffered_msg_queue and this._msg_queue to use unshift https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/unshift, removing the need to reverse the array to pop elements in fifo order Signed-off-by: Tadhg Mulkern<[email protected]>
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: Nico Rikken <[email protected]>
… well as improving build Signed-off-by: James Sutton <[email protected]>
…ulkern/paho.mqtt.javascript into tmulkern-remove-reverse-call-on-arrays
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: Jannik Hunziker <[email protected]>
Signed-off-by: Jannik Hunziker <[email protected]>
Signed-off-by: Jannik Hunziker <[email protected]>
Signed-off-by: Jannik Hunziker <[email protected]>
Signed-off-by: James Sutton <[email protected]>
…tignore and readme. Signed-off-by: James Sutton <[email protected]>
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: Michael Zak <[email protected]>
…vascript into greenstone7-develop
…t.javascript into svarogg-multiple_topics
Signed-off-by: James Sutton <[email protected]>
Signed-off-by: James Sutton <[email protected]>
…ts. (#153) * Fix global object Signed-off-by: Manuel Iglesias <[email protected]> * Remove references to self Signed-off-by: Manuel Iglesias <[email protected]> * Fix arguments conversion to array Signed-off-by: Manuel Iglesias <[email protected]> * Use simple in-memory fake of localStorage when global one is not available Signed-off-by: Manuel Iglesias <[email protected]>
Signed-off-by: James Sutton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.