Handle cases where localStorage access is denied #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In browsers when localStorage access is disabled for your domain the browsers will throw an Access denied error if you try to even read the localStorage property. This commit adds try/catch logic to handle the error and use the in-memory fallback. Signed-off-by: Matt Cowan <[email protected]>
|
Any idea when this might be merged? |
|
Yes, when I figure out how to fix the build! Hopefully, soon. |
|
Hey @icraggs any chance you could tag/release a minor bump to include this? Would be greatly appreciated! |
|
Hey @jpwsutton just a friendly poke on this. Would love to see a minor bump release. |
|
it will be nice, if u make realase with that change guys |
|
For anyone who wants to patch this in their project: https://www.npmjs.com/package/patch-package paho-mqtt is obviously no longer maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In browsers when localStorage access is disabled for your domain the
browsers will throw an Access denied error if you try to even read the
localStorage property. This commit adds try/catch logic to handle the
error and use the in-memory fallback.
Signed-off-by: Matt Cowan [email protected]