-
Notifications
You must be signed in to change notification settings - Fork 98
(add) KIT Company Certificate Management - OpenAPI #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Cvetanka-ZF i can fix the DEPENDENCIES Problem. Please be aware also to include your new YAML file also to the .tractus file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, especially as it matches the API defined in CX-0135 (It would be great, if the openapi file will be added to the standard in the next cycle, too).
Only one change request, though: As @stephanbcbauer also requested, please add this new api to the .tractusx-file. Otherwise the swagger-documentation won't be created.
Thank you @jSchuetz88 and @stephanbcbauer! I have added the YAML file to the .tractusx-file. (#1251) |
thx. short question, why a new PR? |
oh sorry! It was not in purpose. Do you want me to close that one and do the same from the original PR? |
@maximilianong please do the review here. I think you have more experience here than I have. thanks |
Description
A new (first version) of an openAPI for the Company Certificate Management. Related to standard CX-0135 v.2.3.0 and higher.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: