Skip to content

(add) KIT Company Certificate Management - OpenAPI #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Cvetanka-ZF
Copy link

@Cvetanka-ZF Cvetanka-ZF commented Apr 2, 2025

Description

A new (first version) of an openAPI for the Company Certificate Management. Related to standard CX-0135 v.2.3.0 and higher.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer
Copy link
Member

@Cvetanka-ZF i can fix the DEPENDENCIES Problem. Please be aware also to include your new YAML file also to the .tractus file

Copy link
Member

@jSchuetz88 jSchuetz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, especially as it matches the API defined in CX-0135 (It would be great, if the openapi file will be added to the standard in the next cycle, too).

Only one change request, though: As @stephanbcbauer also requested, please add this new api to the .tractusx-file. Otherwise the swagger-documentation won't be created.

@github-project-automation github-project-automation bot moved this from In Progress to Todo in Tractus-X Webpage Apr 25, 2025
@Cvetanka-ZF
Copy link
Author

Overall looks good to me, especially as it matches the API defined in CX-0135 (It would be great, if the openapi file will be added to the standard in the next cycle, too).

Only one change request, though: As @stephanbcbauer also requested, please add this new api to the .tractusx-file. Otherwise the swagger-documentation won't be created.

Thank you @jSchuetz88 and @stephanbcbauer! I have added the YAML file to the .tractusx-file. (#1251)

@stephanbcbauer
Copy link
Member

Overall looks good to me, especially as it matches the API defined in CX-0135 (It would be great, if the openapi file will be added to the standard in the next cycle, too).
Only one change request, though: As @stephanbcbauer also requested, please add this new api to the .tractusx-file. Otherwise the swagger-documentation won't be created.

Thank you @jSchuetz88 and @stephanbcbauer! I have added the YAML file to the .tractusx-file. (#1251)

thx. short question, why a new PR?

@Cvetanka-ZF
Copy link
Author

Overall looks good to me, especially as it matches the API defined in CX-0135 (It would be great, if the openapi file will be added to the standard in the next cycle, too).
Only one change request, though: As @stephanbcbauer also requested, please add this new api to the .tractusx-file. Otherwise the swagger-documentation won't be created.

Thank you @jSchuetz88 and @stephanbcbauer! I have added the YAML file to the .tractusx-file. (#1251)

thx. short question, why a new PR?

oh sorry! It was not in purpose. Do you want me to close that one and do the same from the original PR?

@stephanbcbauer
Copy link
Member

@maximilianong please do the review here. I think you have more experience here than I have. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants