doc: update Digital Twin KIT #569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to Operating Model eclipse-tractusx#568 was updated + CX-0002 now published + editorial changes
Links in Chapter CX-Standards updated + mentioned that now 2024-03 standards are described + minor updates
minor updates
minor changes
arnoweiss
approved these changes
Dec 20, 2023
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
fix number and add more text
arnoweiss
approved these changes
Jan 4, 2024
arnoweiss
reviewed
Jan 16, 2024
docs-kits/kits/Digital Twin Kit/page_software-operation-view.md
Outdated
Show resolved
Hide resolved
florianrusch-zf
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Many thanks for the changes! To me, the changes seem to be very beneficial for the users.
I would recommend you to configure your IDE/editor to automatically remove the spaces at the end ;-) Behind this link you can find instructions on how to do that for vscode: https://stackoverflow.com/a/30884298
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
docs-kits/kits/Digital Twin Kit/Software Development View/page_software-development-view.md
Outdated
Show resolved
Hide resolved
…_software-development-view.md remove unnecessary space Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Start Column with upper letter for consistency with other columns
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
|
@florianrusch-zf Thanks for your careful review. I followed all of your suggestions. Now it should be fine. |
Comment on lines
+28
to
+29
| | Digital Twin Registry | A registry for digital twins, each digital twin providing the endpoints of its submodels. <br> The registry is adhering to the AAS Registry API. | [Tractus-X Digital Twin Registry](https://github.com/eclipse-tractusx/sldt-digital-twin-registry) | CX - 0002 | | ||
| | Submodel Server | The data source adhering to a subset of the Submodel API as defined in AAS Part-2 3.0. | [FA³ST-Framework](https://github.com/FraunhoferIOSB/FAAAST-Service), <br/> [Eclipse Basyx](https://github.com/eclipse-basyx/basyx-java-sdk), <br> [AASX Server](https://github.com/admin-shell-io/aasx-server) | CX - 0002 | |
There was a problem hiding this comment.
As @arnoweiss pointed out, line breakes in tables need to be <br/> and NOT <br>.
Suggested change
| | Digital Twin Registry | A registry for digital twins, each digital twin providing the endpoints of its submodels. <br> The registry is adhering to the AAS Registry API. | [Tractus-X Digital Twin Registry](https://github.com/eclipse-tractusx/sldt-digital-twin-registry) | CX - 0002 | | |
| | Submodel Server | The data source adhering to a subset of the Submodel API as defined in AAS Part-2 3.0. | [FA³ST-Framework](https://github.com/FraunhoferIOSB/FAAAST-Service), <br/> [Eclipse Basyx](https://github.com/eclipse-basyx/basyx-java-sdk), <br> [AASX Server](https://github.com/admin-shell-io/aasx-server) | CX - 0002 | | |
| | Digital Twin Registry | A registry for digital twins, each digital twin providing the endpoints of its submodels. <br/> The registry is adhering to the AAS Registry API. | [Tractus-X Digital Twin Registry](https://github.com/eclipse-tractusx/sldt-digital-twin-registry) | CX - 0002 | | |
| | Submodel Server | The data source adhering to a subset of the Submodel API as defined in AAS Part-2 3.0. | [FA³ST-Framework](https://github.com/FraunhoferIOSB/FAAAST-Service), <br/> [Eclipse Basyx](https://github.com/eclipse-basyx/basyx-java-sdk), <br/> [AASX Server](https://github.com/admin-shell-io/aasx-server) | CX - 0002 | |
|
@BirgitBoss @arnoweiss : is this PR still valid after the release? or can we close it? |
This was referenced Mar 15, 2024
|
All relevant changes were accepted by #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to Digital Twin KIT