Skip to content

docs: adjust trg 4.03 on userid #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

almadigabor
Copy link
Contributor

@almadigabor almadigabor commented Jan 4, 2024

Description

Fixes eclipse-tractusx/sig-infra#369

Adjusted the user ids in the Pod template and added a recommendation section to look for user id created in the base image.


I would consider adding more fields as described in the Kubernetes docs to further enhance security like runAsGroup, fsGroup and also dropping capabilities. I would welcome some suggestions here.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@almadigabor almadigabor requested a review from Siegfriedk January 5, 2024 09:26
@almadigabor almadigabor self-assigned this Jan 5, 2024
tomaszbarwicki
tomaszbarwicki previously approved these changes Jan 5, 2024
Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just a minor thing as I believe runAsUser is enough to set at Pod level, not sure if there is a reason to duplicate it at container level in the k8s manifest.

@almadigabor
Copy link
Contributor Author

Changes LGTM, just a minor thing as I believe runAsUser is enough to set at Pod level, not sure if there is a reason to duplicate it at container level in the k8s manifest.

You're right, I'll remove that part. Specifying on container level just overwrites the Pod level setting.

Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 0edff6b into main Jan 19, 2024
@almadigabor almadigabor deleted the docs/trg-403-align-on-userid branch January 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRG 4.03: Align on userid
3 participants