feat: get clusterPort #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
commented
Jan 18, 2017
| @@ -77,7 +78,16 @@ class Master extends EventEmitter { | |||
|
|
|||
| this.onExit(); | |||
|
|
|||
| this.forkAgentWorker(); | |||
| getFreePort((err, port) => { | |||
There was a problem hiding this comment.
嗯, 可以抽出来, 在 egg-bin 那边也用到了
https://github.com/eggjs/egg-bin/blob/master/lib/helper.js#L76
popomore
force-pushed
the
cluster-port
branch
from
e166cbf to
a184e2a
Compare
Current coverage is 95.50% (diff: 100%)@@ master #12 diff @@
==========================================
Files 7 7
Lines 259 267 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 247 255 +8
Misses 12 12
Partials 0 0
|
popomore
force-pushed
the
cluster-port
branch
from
a184e2a to
a196d2b
Compare
|
@fengmk2 @gxcsoccer 这个看看 |
atian25
reviewed
Jan 20, 2017
| @@ -77,7 +78,17 @@ class Master extends EventEmitter { | |||
|
|
|||
| this.onExit(); | |||
|
|
|||
| this.forkAgentWorker(); | |||
| detectPort((err, port) => { | |||
There was a problem hiding this comment.
egg-bin 是另外一个功能？这个是 cluster-client 的端口
fengmk2
approved these changes
Jan 20, 2017
|
发个 minor |
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
3 tasks
popomore
added a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
fengmk2
pushed a commit
to eggjs/egg
that referenced
this pull request
Jan 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Closes eggjs/egg#219