Fix expressions with multiple operators. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expressions such as ``1 +2;`` or ``300*200`` work, but expressions which have multiple operations do not work. For example: ``1+2+3+4`` does not work, and has to be put in a chain of parentheses to get it to work. The other valid expressions are getting evaluated to the value of the first operator, for instance, ``1*2*3`` becomes 2, by evaluating 1*2 and so on. This can be solved by adding a loop, converting the first two expressions into ``lhs`` and continuing until there are no more ``pair``s.
|
Thanks! this was left as an exercise :) please add some tests to test your changes. |
Fixed mistake in making assertion of ``1 + 2 +3 == 2+2+3``
Yet another attempt to make rustfmt happy.
|
I really apologise for this series of fails. This time I tested it with
I just want to know if you plan to merge this change or do you want to include it in some "solutions" section in the book as it was an exercise. |
|
It's great now! thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expressions such as
1 +2;or300*200work, but expressions which have multiple operations do not work. For example:1+2+3+4does not work, and has to be put in a chain of parentheses to get it to work. The other valid expressions are getting evaluated to the value of the first operator, for instance,1*2*3becomes 2, by evaluating 1*2 and so on.This can be solved by adding a loop, converting the first two expressions into
lhsand continuing until there are no morepairs.