Use features to describe LLVM wrapper instead of branch #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit changes grammar structure to allow the first (and only) term to be wrapped in parentheses. There is still a bug of not allowing negative numbers as the first number. See bug report #17 |
Closed
|
Thanks for the fixes! The changes look good. Please fix the style-check with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading the information on the inkwell README, we should be using features instead of branch names. Branch naming is sometimes chaotic and unreliable. Instead, use features and list the version of llvm you are using. There is a table under inkwell's Usage. The general scheme though is "llvm[major]-[minor]" and doesn't include patches.