-
Notifications
You must be signed in to change notification settings - Fork 232
chore: include http apm client #3507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
approved these changes
Jul 29, 2023
This was referenced Aug 3, 2023
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…astic#3507) This moves the apm-nodejs-http-client.git code into "{lib,test}/apm-client/http-apm-client/..." in this repo. This will help maintenance of multiple active branches of the APM agent. The only changes are to rename the export to `HttpApmClient` and adjust require paths. Some functions were moved from lib/apm-client/http-apm-client.js to lib/apm-client/apm-client.js to clarify. Closes: elastic#3506 Co-authored-by: Trent Mick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding source code from https://github.com/elastic/apm-nodejs-http-client into the
apm-client
module. Summary of the changes:createApmClient
methodhttp-apm-client.js
and name the export toHttpApmClient
Closes #3506
Checklist