feat: support sourcemap resolution for *ESM* stack frames in captured APM errors #4578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thew change is quite straight forward and not changing existing behavior. I'm okay to not have a test if it requires to have another TypeScript project as a fixture. |
david-luna
approved these changes
Apr 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also modernizes the examples/typescript/... a bit and (notably) changes it to use ESM.
This was the repro example I was using for this fix -- though I removed the
apm.captureError(...)I was manually using in examples/typescript/index.ts for dev.Yes, I don't have a test case here. We should discuss if we're going to require that.