refactored span stack and added contextvars as alternative for threadlocals #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the v2 API. The largest change is that the queue moved from `TransactionStore` to `Transport`, and that instead of queuing Python objects, it queues (by default compressed) lines of JSON. Another large conceptual change is that events (errors, transactions and spans) are immediately queued when they are finished. Architecturally, `elasticapm.base.Client` does only have one single method to interact with the transport layer, `queue()`, which in turn calls the transports `queue` method. `send`, `send_remote`, `encode` etc. are all removed.
…locals this is a partial "import" of the asyncio work done in elastic#252, sans the asyncio specific extensions
|
Merged into 4.x branch |
graphaelli
approved these changes
Sep 20, 2018
|
|
||
| thread_local = threading.local() | ||
| thread_local.transaction = None | ||
| elasticapm_span_var = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a partial "import" of the asyncio work done in #252, sans the
asyncio specific extensions