Execution context - use thread locals if gevent/eventlet has monkey patched it #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
reviewed
Apr 9, 2019
| return execution_context | ||
|
|
||
|
|
||
| def threading_local_monkey_patched(): |
There was a problem hiding this comment.
While we're at it, it might make sense to do the same check for eventlet
http://eventlet.net/doc/patching.html#eventlet.patcher.is_monkey_patched
|
jenkins test this |
|
Oops, sorry for closing the PR, got ticket numbers mixed up in the commit message for 5337c43 🤦♂️ |
|
@ramshaw888 The build currently fails because of a linting issue. We use I'll make sure to add these steps to our contributing guidelines. |
ramshaw888
force-pushed
the
monkey-thread-locals
branch
from
29bfaa4 to
6d9a7ff
Compare
ramshaw888
changed the title
ramshaw888
force-pushed
the
monkey-thread-locals
branch
from
d6c486d to
2ebdf7c
Compare
ramshaw888
added a commit
to ramshaw888/apm-agent-python
that referenced
this pull request
Apr 9, 2019
…atched it elastic#453 * Extract out logic to decide which backing to use for execution_context into a function init_execution_context * Check if gevent or eventlet has monkey patched _threading.local, if it has then use elasticapm.context.threadlocal as the backing.
…atched it elastic#453 * Extract out logic to decide which backing to use for execution_context into a function init_execution_context * Check if gevent or eventlet has monkey patched _threading.local, if it has then use elasticapm.context.threadlocal as the backing.
ramshaw888
force-pushed
the
monkey-thread-locals
branch
from
2ebdf7c to
58dc200
Compare
|
I think the closing/reopening might have messed up the appveyor integration. Will close and re-open in a new PR. |
beniwohli
pushed a commit
that referenced
this pull request
Apr 10, 2019
…atched it (#454) * Execution context - use thread locals if gevent/eventlet has monkey patched it #453 * Extract out logic to decide which backing to use for execution_context into a function init_execution_context * Check if gevent or eventlet has monkey patched _threading.local, if it has then use elasticapm.context.threadlocal as the backing. closes #451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution_contextinto a functioninit_execution_contextgeventoreventlethas monkey patched_threading.local, if it has then useelasticapm.context.threadlocalas the backing.