Skip to content

docs: update broken links for apm-guide-ref #1385 #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2022
Merged

docs: update broken links for apm-guide-ref #1385 #1143

merged 4 commits into from
Jan 24, 2022

Conversation

ollyhowell
Copy link
Contributor

@ollyhowell ollyhowell commented Jan 20, 2022 •
edited by bmorelli25
Loading

Links updated as per elastic/observability-docs#1385. The old links will break when 7.17 releases. This PR and all backports must be merged before the 7.17 release. Thanks!

Backports

@ollyhowell ollyhowell requested a review from bmorelli25 January 20, 2022 16:43
@apmmachine
Copy link
Contributor

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 63.8 KiB 20.3 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 57.7 KiB 18.8 KiB 💚 0 Bytes

@apmmachine
Copy link
Contributor

apmmachine commented Jan 20, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-23T23:58:50.425+0000

  • Duration: 12 min 44 sec

  • Commit: 22e6dfc

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

bmorelli25
bmorelli25 reviewed Jan 20, 2022
View reviewed changes
@bmorelli25 bmorelli25 added the Team:Docs Label for the Observability docs team label Jan 20, 2022
@bmorelli25 bmorelli25 marked this pull request as ready for review January 20, 2022 19:36
bmorelli25
bmorelli25 approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Olly! I'll get started on the backports.

@bmorelli25 bmorelli25 requested a review from a team January 20, 2022 19:37
This was referenced Jan 20, 2022
Merged
Merged
Merged
@bmorelli25
Copy link
Member

It looks like updating the commit messages fixed this PR, but it unfortunately didn't fix the backports.

@bmorelli25 bmorelli25 merged commit 31b33d0 into main Jan 24, 2022
@bmorelli25 bmorelli25 deleted the FixAPMLinksOlly branch January 24, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ollyhowell @apmmachine @bmorelli25