Skip to content

fix: update module name to use github url #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 23, 2022

Conversation

kruskall
Copy link
Member

The previous module name was invalid and using a subfolder to
store the source code was creating additional burden (e.g.
you cannot 'git clone && make'.

Update the module name to use the github url and flatten the
directory structure.

Closes #261

The previous module name was invalid and using a subfolder to
store the source code was creating additional burden (e.g.
you cannot 'git clone && make'.

Update the module name to use the github url and flatten the
directory structure.
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Aug 22, 2022
@apmmachine
Copy link

apmmachine commented Aug 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-23T07:25:20.500+0000

  • Duration: 7 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 160
Skipped 2
Total 162

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall
Copy link
Member Author

/test

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments on the readme. Let me know what you think.

README.md Outdated

See [contributing](CONTRIBUTING.md) for details about reporting bugs, requesting features, or code contributions.

## Testing unreleased versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is developer-oriented, and not relevant to end users. Although we have end-user docs, I think it would still be nice to keep this landing page minimal.

What do you think about moving all of the below with the exception of License and Release to a new TESTING.md doc? License should stay in this doc. And maybe link to RELEASE.md from CONTRIBUTING.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I agree, that's a lot cleaner!

And maybe link to RELEASE.md from CONTRIBUTING.md?

I'm not sure about this. Release is already linked in the readme and won't provide much value to contributors as it's not something they would worry about. Maybe we should link to TESTING.md ? WDYT ?

@kruskall kruskall requested a review from axw August 23, 2022 01:54
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Just spotted a few typos in the existing docs.

kruskall and others added 2 commits August 23, 2022 09:07
Co-authored-by: Andrew Wilkins <[email protected]>
Co-authored-by: Andrew Wilkins <[email protected]>
@kruskall
Copy link
Member Author

/test

@kruskall kruskall merged commit 9494d78 into elastic:main Aug 23, 2022
@kruskall kruskall deleted the fix/module-name branch August 23, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update module name to be consistent with other elastic projects
3 participants