Skip to content

Use keyless authentication for the release #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jun 24, 2024

Use elastic/oblt-actions/aws/[email protected] for authenticating keyless with OIDC to the AWS account.

@reakaleek reakaleek requested a review from a team June 24, 2024 08:45
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Jun 24, 2024
@reakaleek reakaleek self-assigned this Jun 24, 2024
dmathieu
dmathieu previously approved these changes Jun 24, 2024
@reakaleek reakaleek changed the title Use keyless authentication for the releasee Use keyless authentication for the release Jun 24, 2024
kruskall
kruskall previously approved these changes Jun 24, 2024
v1v
v1v previously approved these changes Jun 25, 2024
@reakaleek
Copy link
Member Author

I need to do some additional testing.

I'm not fully confident that it will work because of

- AWS_ACCESS_KEY_ID={{ .Env.AWS_ACCESS_KEY_ID }}
- AWS_SECRET_ACCESS_KEY={{ .Env.AWS_SECRET_ACCESS_KEY }}

Need to check if I also need to pass AWS_SESSION_TOKEN and/or AWS_SECURITY_TOKEN

@reakaleek reakaleek dismissed stale reviews from v1v, kruskall, and dmathieu via 6d8a6b8 June 25, 2024 08:38
@reakaleek
Copy link
Member Author

reakaleek commented Jun 25, 2024

Added AWS_SESSION_TOKEN in d98c84e

because I saw that the aws/auth action adds the AWS_SESSION_TOKEN as an environment variable.

image

@reakaleek reakaleek requested review from dmathieu, kruskall and v1v June 25, 2024 08:41
@reakaleek reakaleek merged commit ae49a75 into main Jun 25, 2024
10 checks passed
@reakaleek reakaleek deleted the feature/keyless-release branch June 25, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants